Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Azure policy 2019-01-01 API version specifications #6393

Merged
merged 3 commits into from
Jul 5, 2019
Merged

Azure policy 2019-01-01 API version specifications #6393

merged 3 commits into from
Jul 5, 2019

Conversation

RamyasreeChakka
Copy link
Member

Azure policy 2019-01-01 API version specifications.

@openapi-sdkautomation
Copy link

openapi-sdkautomation bot commented Jun 19, 2019 •
edited
Loading

SDK Automation [Logs] (Generated from c944c9a)

Pending Python: Azure/azure-sdk-for-python
  • Package generation pending.
Pending Java: Azure/azure-sdk-for-java
  • Package generation pending.
Pending Go: Azure/azure-sdk-for-go
  • Package generation pending.
Pending JavaScript: Azure/azure-sdk-for-js
  • Package generation pending.

@AutorestCI
Copy link

AutorestCI commented Jun 19, 2019 •
edited
Loading

Automation for azure-sdk-for-ruby

Nothing to generate for azure-sdk-for-ruby

@azuresdkci azuresdkci requested a review from mmyyrroonn June 19, 2019 23:52
@AutorestCI AutorestCI mentioned this pull request Jun 19, 2019
Closed
@AutorestCI
Copy link

AutorestCI commented Jun 19, 2019 •
edited
Loading

Automation for azure-sdk-for-python

A PR has been created for you based on this PR content.

Once this PR will be merged, content will be added to your service PR:
Azure/azure-sdk-for-python#6155

@azuresdkci
Copy link
Contributor

Can one of the admins verify this patch?

@AutorestCI AutorestCI mentioned this pull request Jun 19, 2019
Closed
@AutorestCI
Copy link

AutorestCI commented Jun 19, 2019 •
edited
Loading

Automation for azure-sdk-for-go

A PR has been created for you based on this PR content.

Once this PR will be merged, content will be added to your service PR:
Azure/azure-sdk-for-go#5202

@AutorestCI AutorestCI mentioned this pull request Jun 20, 2019
Merged
@AutorestCI
Copy link

AutorestCI commented Jun 20, 2019 •
edited
Loading

Automation for azure-sdk-for-java

The initial PR has been merged into your service PR:
Azure/azure-sdk-for-java#3337

@mmyyrroonn mmyyrroonn added the WaitForARMFeedback <valid label in PR review process> add this label when ARM review is required label Jun 20, 2019
@pilor pilor self-requested a review June 20, 2019 23:19
@sergey-shandar
Copy link
Contributor

@daschult any idea why Automation for SDK is failing for these languages?

@sergey-shandar
Copy link
Contributor

@anuchandy any idea why Java SDK is failling?

[ERROR] interface WithMicrosoft.Resource {
[ERROR] ^
[ERROR] /7/2/resources/resource-manager/v2019_05_01/src/main/java/com/microsoft/azure/management/resources/v2019_05_01/DeploymentExtended.java:74: error: = expected
[ERROR] WithProperties withExistingMicrosoft.Resource(String groupId);
[ERROR] ^
[ERROR] /7/2/resources/resource-manager/v2019_05_01/src/main/java/com/microsoft/azure/management/resources/v2019_05_01/DeploymentExtended.java:74: error: <identifier> expected
[ERROR] WithProperties withExistingMicrosoft.Resource(String groupId);

@mmyyrroonn
Copy link
Contributor

@pilor Hi. if you are good for this PR, could you help remove WaitForARMFeedback label and add signedoff label ?

@mmyyrroonn
Copy link
Contributor

@anuchandy any idea why Java SDK is failling?

[ERROR] interface WithMicrosoft.Resource {
[ERROR] ^
[ERROR] /7/2/resources/resource-manager/v2019_05_01/src/main/java/com/microsoft/azure/management/resources/v2019_05_01/DeploymentExtended.java:74: error: = expected
[ERROR] WithProperties withExistingMicrosoft.Resource(String groupId);
[ERROR] ^
[ERROR] /7/2/resources/resource-manager/v2019_05_01/src/main/java/com/microsoft/azure/management/resources/v2019_05_01/DeploymentExtended.java:74: error: <identifier> expected
[ERROR] WithProperties withExistingMicrosoft.Resource(String groupId);

@anuchandy any update or idea why Java SDK is failling? @yaohaizh hi yaohai, could you please take a look?

@RamyasreeChakka
Copy link
Member Author

@myronfanqiu Python, Java, GO SDK jobs were created based on first iteration of this PR. I pushed two commits incorporating comments. Can you please re-trigger all the SDK jobs and merge this pull request?

@RamyasreeChakka
Copy link
Member Author

RamyasreeChakka commented Jun 26, 2019 •
edited
Loading

@myronfanqiu @stankovski
@pilor from my team has signed off on this PR and he doesn't have permissions to remove/add labels. Can you please re-trigger all the SDK jobs and merge this pull request? Python, Java, GO SDK jobs were created based on first iteration of this PR. I pushed two commits after first iteration.

ravbhatnagar
ravbhatnagar reviewed Jun 26, 2019
View reviewed changes
Copy link
Contributor

@ravbhatnagar ravbhatnagar left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@RamyasreeChakka - there is just one change in the 2019-01-01 api version when compared with 2018-05-01. And there are few description changes in 2018-05-01. Is that correct? Why are you shipping a new api-version?

.../resources/resource-manager/Microsoft.Authorization/stable/2019-01-01/policyDefinitions.json Show resolved Hide resolved
...sources/resource-manager/Microsoft.Authorization/stable/2019-01-01/policySetDefinitions.json Show resolved Hide resolved
.../resources/resource-manager/Microsoft.Authorization/stable/2019-01-01/policyDefinitions.json Show resolved Hide resolved
.../resources/resource-manager/Microsoft.Authorization/stable/2019-01-01/policyAssignments.json Show resolved Hide resolved
@ravbhatnagar ravbhatnagar added the ARMChangesRequested <valid label in PR review process>add this label when require changes after ARM review label Jun 26, 2019
@RamyasreeChakka
Copy link
Member Author

@RamyasreeChakka - there is just one change in the 2019-01-01 api version when compared with 2018-05-01. And there are few description changes in 2018-05-01. Is that correct? Why are you shipping a new api-version?

With the new 2019-01-01 version, we added data plane policy support. With the new api-version, ensuring existing clients who are using old api-versions do not break when they do list operation.

@mmyyrroonn
Copy link
Contributor

@RamyasreeChakka Of course. I'm trying to contact @anuchandy to take a look and re-trigger the SDK jobs. Meanwhile, please solve the ARM's requests.

@ravbhatnagar
Copy link
Contributor

Signing off from ARM side.

@ravbhatnagar ravbhatnagar added ARMSignedOff <valid label in PR review process>add this label when ARM approve updates after review and removed ARMChangesRequested <valid label in PR review process>add this label when require changes after ARM review WaitForARMFeedback <valid label in PR review process> add this label when ARM review is required labels Jun 28, 2019
@ghost
Copy link

ghost commented Jul 2, 2019

@openapi sdkautomation rebuild

@mmyyrroonn mmyyrroonn merged commit f6e9639 into Azure:master Jul 5, 2019
@AutorestCI AutorestCI mentioned this pull request Jul 5, 2019
Merged
celikcigdem pushed a commit to celikcigdem/azure-rest-api-specs that referenced this pull request Jul 17, 2019
@RamyasreeChakka @celikcigdem
Azure policy 2019-01-01 API version specifications (Azure#6393)
2b1404b 
* Azure policy 2019-01-01 specs

* Add KeyVault data plane definition example

* Fix typos
@hjhhh3000vitae hjhhh3000vitae mentioned this pull request Aug 13, 2019
Merged
2 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@mentat9 mentat9 mentat9 left review comments

@ravbhatnagar ravbhatnagar ravbhatnagar left review comments

@mmyyrroonn mmyyrroonn mmyyrroonn approved these changes

@pilor pilor pilor approved these changes

@stankovski stankovski Awaiting requested review from stankovski

Assignees

@mmyyrroonn mmyyrroonn

Labels
ARMSignedOff <valid label in PR review process>add this label when ARM approve updates after review
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
8 participants
@RamyasreeChakka @AutorestCI @azuresdkci @sergey-shandar @mmyyrroonn @ravbhatnagar @pilor @mentat9